Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
OS X Builds again?
12-20-2008, 02:38 PM,
#10
 
abs1nth Wrote:either some scons magic to include pch.h in every compile or add a include pch.h to every file. don't remember how that was done previously.

Previously there was an #include "pch.h" in every file. It seems kind of messy to do it that way, but I can't think of any problem with it besides just obscuring exactly what external library includes your file is depending on.

But, prior to the patch you already fixed the includes for everything to be correct on OSX? If so, then maybe it's not worth the effort to add #include pch.h everywhere; I don't expect any new external dependencies. Thoughts?
Reply


Messages In This Thread
OS X Builds again? - by cotharyus - 12-13-2008, 09:30 AM
[No subject] - by joevenzon_phpbb2_import3 - 12-14-2008, 01:20 AM
[No subject] - by cotharyus - 12-16-2008, 12:44 PM
[No subject] - by joevenzon_phpbb2_import3 - 12-16-2008, 10:38 PM
[No subject] - by abs1nth - 12-18-2008, 08:44 AM
[No subject] - by charlieg - 12-18-2008, 12:30 PM
[No subject] - by joevenzon_phpbb2_import3 - 12-18-2008, 05:25 PM
[No subject] - by joevenzon_phpbb2_import3 - 12-18-2008, 05:28 PM
[No subject] - by abs1nth - 12-20-2008, 08:45 AM
[No subject] - by joevenzon_phpbb2_import3 - 12-20-2008, 02:38 PM
[No subject] - by abs1nth - 12-21-2008, 09:59 AM

Forum Jump:


Users browsing this thread: 1 Guest(s)