r2903 won't build

[Timo 6]

Somewhere between r3030 and 3064 I have got a bunch of errors when building similar to this one:

Code:

/Developer/SDKs/MacOSX10.5.sdk/usr/include/c++/4.2.1/tr1/hashtable: In member function 'typename std::tr1::hashtable<Key, Value, Allocator, ExtractKey, Equal, H1, H2, H, RehashPolicy, cache_hash_code, mutable_iterators, unique_keys>::const_iterator std::tr1::hashtable<Key, Value, Allocator, ExtractKey, Equal, H1, H2, H, RehashPolicy, cache_hash_code, mutable_iterators, unique_keys>::find(const Key&) const [with Key = std::basic_string<char, std::char_traits<char>, std::allocator<char> >, Value = std::pair<const std::basic_string<char, std::char_traits<char>, std::allocator<char> >, StringId>, Allocator = std::allocator<std::pair<const std::basic_string<char, std::char_traits<char>, std::allocator<char> >, StringId> >, ExtractKey = Internal::extract1st<std::pair<const std::basic_string<char, std::char_traits<char>, std::allocator<char> >, StringId> >, Equal = std::equal_to<std::basic_string<char, std::char_traits<char>, std::allocator<char> > >, H1 = std::tr1::hash<std::basic_string<char, std::char_traits<char>, std::allocator<char> > >, H2 = Internal::mod_range_hashing, H = Internal::default_ranged_hash, RehashPolicy = Internal::prime_rehash_policy, bool cache_hash_code = false, bool mutable_iterators = true, bool unique_keys = true]':
/Users/tim/Applications/VDrift/SVN/vdrift/tools/osx/../../include/gl3v/stringidmap.h:50:   instantiated from here
/Developer/SDKs/MacOSX10.5.sdk/usr/include/c++/4.2.1/tr1/hashtable:1135: error: passing 'const std::tr1::hashtable<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<const std::basic_string<char, std::char_traits<char>, std::allocator<char> >, StringId>, std::allocator<std::pair<const std::basic_string<char, std::char_traits<char>, std::allocator<char> >, StringId> >, Internal::extract1st<std::pair<const std::basic_string<char, std::char_traits<char>, std::allocator<char> >, StringId> >, std::equal_to<std::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::tr1::hash<std::basic_string<char, std::char_traits<char>, std::allocator<char> > >, Internal::mod_range_hashing, Internal::default_ranged_hash, Internal::prime_rehash_policy, false, true, true>' as 'this' argument of 'typename std::tr1::hashtable<Key, Value, Allocator, ExtractKey, Equal, H1, H2, H, RehashPolicy, cache_hash_code, mutable_iterators, unique_keys>::node* std::tr1::hashtable<Key, Value, Allocator, ExtractKey, Equal, H1, H2, H, RehashPolicy, cache_hash_code, mutable_iterators, unique_keys>::find_node(Internal::hash_node<Value, cache_hash_code>*, const Key&, typename std::tr1::hashtable<Key, Value, Allocator, ExtractKey, Equal, H1, H2, H, RehashPolicy, cache_hash_code, mutable_iterators, unique_keys>::hash_code_t) [with Key = std::basic_string<char, std::char_traits<char>, std::allocator<char> >, Value = std::pair<const std::basic_string<char, std::char_traits<char>, std::allocator<char> >, StringId>, Allocator = std::allocator<std::pair<const std::basic_string<char, std::char_traits<char>, std::allocator<char> >, StringId> >, ExtractKey = Internal::extract1st<std::pair<const std::basic_string<char, std::char_traits<char>, std::allocator<char> >, StringId> >, Equal = std::equal_to<std::basic_string<char, std::char_traits<char>, std::allocator<char> > >, H1 = std::tr1::hash<std::basic_string<char, std::char_traits<char>, std::allocator<char> > >, H2 = Internal::mod_range_hashing, H = Internal::default_ranged_hash, RehashPolicy = Internal::prime_rehash_policy, bool cache_hash_code = false, bool mutable_iterators = true, bool unique_keys = true]' discards qualifiers

By the way, I've added/removed some files to the xcode project and adjusted some gl.h and glew.h headers to work on mac. If I could have SVN access to check in these changes, that would be great. On that topic, does it make any difference if we move the header files in src/gl3v to include/gl3v to be tidier?

[NaN]

I think we had this before. GCC4.2.1 + std::tr1::unordered_map = compile errors.

MacOS could use boost for this. What about a separate hashmap.h header selecting/wrapping the available unordered_map implementation?

[joevenzon]

Another option: apparently GCC 4.3 is available through darwinports, which should fix the bug.

[Timo 6]

So it is (on macports anyway, is that what you mean?) - there are various versions - 4.04, 4.1.2, 4.2.4, 4.3.5, 4.4.5, 4.5.2 and prerelease BETA 4.6-20110212 - will it make a different if I go with the latest stable, rather than 4.3?

[joevenzon]

Not from what I've read. I don't actually have OS X, I'm just going off of google results, so ... take things I say with a grain of salt. :-)

[abs1nth]

Another option: apparently GCC 4.3 is available through darwinports, which should fix the bug.

requiring an non-apple provided gcc on mac os x is a bad idea

So it is (on macports anyway, is that what you mean?) - there are various versions

just save yourself the trouble and dont do it. it wont work in xcode easily anyway.

[joevenzon]

abs1nth: between changing to a newer GCC and adding an OSX dependency on boost, is the latter easier to set up?

[abs1nth]

boost would be just another dependency, requiring non-appple-gcc would be insanity ;-)

[Timo 6]

How far towards being fixed is this? I want to check out the new car and the shared track objects.

[joevenzon]

I think we're waiting for an OSX dev to take up this issue. The fix is probably to integrate boost and set up boost::unordered_map to replace std::tr1::unordered_map when compiling on OSX.

[NaN]

Maybe something like this

Code:

#ifdef __APPLE__
    #include <boost/tr1/unordered_map.hpp>
#elif _MSC_VER
    #include <unordered_map>
#else
    #include <tr1/unordered_map>
#endif

Only gl3v code is affected atm. I can commit a header + gl3v changes if there are no objections.

[abs1nth]

Maybe something like this
Only gl3v code is affected atm. I can commit a header + gl3v changes if there are no objections.

thanks, i'll add boost so this actually works.

[abs1nth]

ok r3095 builds and runs.

i've commited only a "minimal" portion that is required of boost, i.e. about 1800 of 8300 files ;-)

[Timo 6]

Still not building 125 out of 137 errors are gone, but these remain:

Code:

Build vdrift of project vdrift with configuration Debug

CompileC /Applications/VDrift/SVN/vdrift/build/vdrift.build/Debug/vdrift.build/Objects-normal/i386/drawable.o ../../src/drawable.cpp normal i386 c++ com.apple.compilers.gcc.4_2
cd /Applications/VDrift/SVN/vdrift/tools/osx
setenv LANG en_US.US-ASCII
/Developer/usr/bin/gcc-4.2 -x c++ -arch i386 -fmessage-length=0 -pipe -Wno-trigraphs -fpascal-strings -fasm-blocks -O0 -mdynamic-no-pic -DDEBUG=1 -isysroot /Developer/SDKs/MacOSX10.6.sdk -fvisibility=hidden -fvisibility-inlines-hidden -mmacosx-version-min=10.4 -gdwarf-2 -I/Applications/VDrift/SVN/vdrift/build/vdrift.build/Debug/vdrift.build/VDrift.hmap -F/Applications/VDrift/SVN/vdrift/build/Debug -F/Applications/VDrift/SVN/vdrift/tools/osx -F/Applications/VDrift/SVN/vdrift/tools/osx -I/Applications/VDrift/SVN/vdrift/build/Debug/include -I. -I../../src -I../../bullet -I../../include -ISDL.framework/Headers -I/Applications/VDrift/SVN/vdrift/build/vdrift.build/Debug/vdrift.build/DerivedSources/i386 -I/Applications/VDrift/SVN/vdrift/build/vdrift.build/Debug/vdrift.build/DerivedSources -c /Applications/VDrift/SVN/vdrift/tools/osx/../../src/drawable.cpp -o /Applications/VDrift/SVN/vdrift/build/vdrift.build/Debug/vdrift.build/Objects-normal/i386/drawable.o

/Applications/VDrift/SVN/vdrift/tools/osx/../../src/drawable.cpp: In member function 'RenderModelExternal& DRAWABLE::generateRenderModelData(GLWrapper&, StringIdMap&)':
/Applications/VDrift/SVN/vdrift/tools/osx/../../src/drawable.cpp:75: error: 'class RenderModelExternalDrawable' has no member named 'clearTextureCache'
/Applications/VDrift/SVN/vdrift/tools/osx/../../src/drawable.cpp:88: error: 'class RenderModelExternalDrawable' has no member named 'clearUniformCache'

CompileC /Applications/VDrift/SVN/vdrift/build/vdrift.build/Debug/vdrift.build/Objects-normal/i386/graphics_gl3v.o ../../src/graphics_gl3v.cpp normal i386 c++ com.apple.compilers.gcc.4_2
cd /Applications/VDrift/SVN/vdrift/tools/osx
setenv LANG en_US.US-ASCII
/Developer/usr/bin/gcc-4.2 -x c++ -arch i386 -fmessage-length=0 -pipe -Wno-trigraphs -fpascal-strings -fasm-blocks -O0 -mdynamic-no-pic -DDEBUG=1 -isysroot /Developer/SDKs/MacOSX10.6.sdk -fvisibility=hidden -fvisibility-inlines-hidden -mmacosx-version-min=10.4 -gdwarf-2 -I/Applications/VDrift/SVN/vdrift/build/vdrift.build/Debug/vdrift.build/VDrift.hmap -F/Applications/VDrift/SVN/vdrift/build/Debug -F/Applications/VDrift/SVN/vdrift/tools/osx -F/Applications/VDrift/SVN/vdrift/tools/osx -I/Applications/VDrift/SVN/vdrift/build/Debug/include -I. -I../../src -I../../bullet -I../../include -ISDL.framework/Headers -I/Applications/VDrift/SVN/vdrift/build/vdrift.build/Debug/vdrift.build/DerivedSources/i386 -I/Applications/VDrift/SVN/vdrift/build/vdrift.build/Debug/vdrift.build/DerivedSources -c /Applications/VDrift/SVN/vdrift/tools/osx/../../src/graphics_gl3v.cpp -o /Applications/VDrift/SVN/vdrift/build/vdrift.build/Debug/vdrift.build/Objects-normal/i386/graphics_gl3v.o

In file included from /Applications/VDrift/SVN/vdrift/tools/osx/../../include/unordered_map.h:2,
                 from /Applications/VDrift/SVN/vdrift/tools/osx/../../src/graphics_gl3v.cpp:3:
./boost/tr1/unordered_map.hpp:25: error: 'unordered_map' is already declared in this scope
./boost/tr1/unordered_map.hpp:26: error: 'unordered_multimap' is already declared in this scope
In file included from /Applications/VDrift/SVN/vdrift/tools/osx/../../include/unordered_map.h:3,
                 from /Applications/VDrift/SVN/vdrift/tools/osx/../../src/graphics_gl3v.cpp:3:
./boost/tr1/functional.hpp:131: error: 'hash' is already declared in this scope
/Applications/VDrift/SVN/vdrift/tools/osx/../../src/graphics_gl3v.cpp: In member function 'virtual void GRAPHICS_GL3V::DrawScene(std::ostream&)':
/Applications/VDrift/SVN/vdrift/tools/osx/../../src/graphics_gl3v.cpp:283: error: 'class Renderer' has no member named 'getPassNames'
/Applications/VDrift/SVN/vdrift/tools/osx/../../src/graphics_gl3v.cpp:286: error: 'class Renderer' has no member named 'getPassEnabled'
/Applications/VDrift/SVN/vdrift/tools/osx/../../src/graphics_gl3v.cpp:288: error: 'class Renderer' has no member named 'getDrawGroups'
/Applications/VDrift/SVN/vdrift/tools/osx/../../src/graphics_gl3v.cpp:367: error: no matching function for call to 'Renderer::render(int&, int&, StringIdMap&, std::map<StringId, std::map<StringId, std::vector<RenderModelExternal*, std::allocator<RenderModelExternal*> >*, std::less<StringId>, std::allocator<std::pair<const StringId, std::vector<RenderModelExternal*, std::allocator<RenderModelExternal*> >*> > >, std::less<StringId>, std::allocator<std::pair<const StringId, std::map<StringId, std::vector<RenderModelExternal*, std::allocator<RenderModelExternal*> >*, std::less<StringId>, std::allocator<std::pair<const StringId, std::vector<RenderModelExternal*, std::allocator<RenderModelExternal*> >*> > > > > >&, std::basic_ostream<char, std::char_traits<char> >&)'
/Applications/VDrift/SVN/vdrift/tools/osx/../../include/gl3v/renderer.h:34: note: candidates are: void Renderer::render(unsigned int, unsigned int, StringIdMap&, std::ostream&)
/Applications/VDrift/SVN/vdrift/tools/osx/../../include/gl3v/renderer.h:41: note:                 void Renderer::render(unsigned int, unsigned int, StringIdMap&, const std::map<StringId, std::vector<RenderModelExternal*, std::allocator<RenderModelExternal*> >, std::less<StringId>, std::allocator<std::pair<const StringId, std::vector<RenderModelExternal*, std::allocator<RenderModelExternal*> > > > >&, std::ostream&)
/Applications/VDrift/SVN/vdrift/tools/osx/../../src/graphics_gl3v.cpp: In member function 'virtual bool GRAPHICS_GL3V::ReloadShaders(const std::string&, std::ostream&, std::ostream&)':
/Applications/VDrift/SVN/vdrift/tools/osx/../../src/graphics_gl3v.cpp:407: error: 'struct RealtimeExportPassInfo' has no member named 'userDefinedFields'
/Applications/VDrift/SVN/vdrift/tools/osx/../../src/graphics_gl3v.cpp:424: error: 'class Renderer' has no member named 'getPassNames'
/Applications/VDrift/SVN/vdrift/tools/osx/../../src/graphics_gl3v.cpp:427: error: 'class Renderer' has no member named 'getUserDefinedFields'

[abs1nth]

maybe your xcode project wasnt updated by SVN because u had local changes?