libvorbis

[joevenzon]

I'm adding music support to VDrift with libvorbis. In the vdrift/SConstruct file I added vorbis/vorbisfile.h to the check_headers list. In vdrift/src/Sconscript I added vorbisfile to the common_libs list. Please modify/add as necessary to make it work for your platforms.

[joevenzon]

Checked in, R1815.

[cotharyus]

This has horribly broken the OS X build.

CompileC /Users/lauasanf/code/build/vdrift.build/Release-Deployment/vdrift.build/Objects-normal/ppc/sound.o /Users/lauasanf/code/vdrift/tools/osx/../../src/sound.cpp normal ppc c++ com.apple.compilers.gcc.4_0
cd /Users/lauasanf/code/vdrift/tools/osx
/usr/bin/gcc-4.0 -x c++ -arch ppc -pipe -Wno-trigraphs -fpascal-strings -fasm-blocks -g -O3 -fmessage-length=0 -mtune=G4 -fvisibility=hidden -fvisibility-inlines-hidden -mmacosx-version-min=10.4 -I/Users/lauasanf/code/build/vdrift.build/Release-Deployment/vdrift.build/vdrift.hmap -mdynamic-no-pic -F/Users/lauasanf/code/build/Release-Deployment -F/Users/lauasanf/code/vdrift/tools/osx -I/Users/lauasanf/code/build/Release-Deployment/include -I../../include -ISDL.framework/Headers -Iode.framework/Headers -I/Users/lauasanf/code/build/vdrift.build/Release-Deployment/vdrift.build/DerivedSources -isysroot /Developer/SDKs/MacOSX10.4u.sdk -include /Library/Caches/com.apple.Xcode.501/SharedPrecompiledHeaders/pch-dxcmspvacvznjgafiylecvgkkmhx/pch.h -c /Users/lauasanf/code/vdrift/tools/osx/../../src/sound.cpp -o /Users/lauasanf/code/build/vdrift.build/Release-Deployment/vdrift.build/Objects-normal/ppc/sound.o
/Users/lauasanf/code/vdrift/tools/osx/../../src/sound.cpp:10:31: error: vorbis/vorbisfile.h: No such file or directory
/Users/lauasanf/code/vdrift/tools/osx/../../src/sound.cpp: In member function 'void SOUNDBUFFER::LoadOGG(const std:tring&, const SOUNDINFO&)':
/Users/lauasanf/code/vdrift/tools/osx/../../src/sound.cpp:792: error: 'vorbis_info' was not declared in this scope
/Users/lauasanf/code/vdrift/tools/osx/../../src/sound.cpp:792: error: 'pInfo' was not declared in this scope
/Users/lauasanf/code/vdrift/tools/osx/../../src/sound.cpp:793: error: 'OggVorbis_File' was not declared in this scope
/Users/lauasanf/code/vdrift/tools/osx/../../src/sound.cpp:793: error: expected `;' before 'oggFile'
/Users/lauasanf/code/vdrift/tools/osx/../../src/sound.cpp:795: error: 'oggFile' was not declared in this scope
/Users/lauasanf/code/vdrift/tools/osx/../../src/sound.cpp:795: error: 'ov_open' was not declared in this scope
/Users/lauasanf/code/vdrift/tools/osx/../../src/sound.cpp:797: error: 'ov_info' was not declared in this scope
/Users/lauasanf/code/vdrift/tools/osx/../../src/sound.cpp:800: error: 'ov_pcm_total' was not declared in this scope
/Users/lauasanf/code/vdrift/tools/osx/../../src/sound.cpp:814: error: 'ov_clear' was not declared in this scope
/Users/lauasanf/code/vdrift/tools/osx/../../src/sound.cpp:830: error: 'ov_read' was not declared in this scope
/Users/lauasanf/code/vdrift/tools/osx/../../src/sound.cpp:838: error: 'ov_clear' was not declared in this scope


Anyone got recommendations or a quick fix for this? If it's something that's going to take some time, I've still got a couple of recent working versions laying around.

[xTs]

you're missing the headers of libvorbis

../src/sound.cpp:10:31: error: vorbis/vorbisfile.h: No such file or directory

[cotharyus]

I'm assuming that would be because libvorbis was not installed on that system?

[cotharyus]

ok, I've got two versions of libvorbis on this system:

spider: root# find / -name vorbisfile.h
/opt/local/include/vorbis/vorbisfile.h
/opt/local/var/macports/software/libvorbis/1.1.2_0/opt/local/include/vorbis/vorbisfile.h
/usr/local/include/vorbis/vorbisfile.h


apparently #include <vorbis> != /usr/local/include || /opt/local/include on OS X. Anyone want to whip up an ifdef for this?

[joevenzon]

I think the proper way to do this is to add /usr/local/include to the include path that's passed to your compiler, which would look like -I/usr/local/include

It should go somewhere in the SConstruct file, I think, but I'm not sure exactly where....

[cotharyus]

Ok - I'm pretty new to this whole OSX thing, so I'll take a look at it. It might be easier than it looks...

[cotharyus]

Line 65 of SConstruct:

CCFLAGS = ['-Wall -I/usr/local/include/'],

- I added the -I/usr/local/include/ (tried it without the trailing / as well) and still get the exact same compile errors. Anyone?

[xTs]

Try to edit line 64.

there're the include path noted.


Something like:
CPPPATH = ['#include', '#tools/osx', '#tools/osx/SDL.framework/Headers','/usr/local/include/'],

[cotharyus]

Yep. You're right. According to Scons.org

Program('hello.c', CPPPATH = ['include', '/home/project/inc'])

Will look like this on POSIX or Linux:

cc -o hello.o -c -Iinclude -I/home/project/inc hello.c

Which means that this:

CPPPATH = ['#include', '/usr/local/include', '#tools/osx', '#tools/osx/SDL.framework/Headers'],

Should be right. Except it's producing the same errors as before....

...yall go on and picture me scratching my head...

[cotharyus]

You know, I'm starting to think there's something I don't know about OS X. Because it's the kind of guy I am, I copied /usr/local/include/vorbis into /vdrift/src/include and did the same with /usr/local/include/ogg - at which point, all objects were created just fine, but in linking - you'd have thought that I hadn't put /usr/local/lib on line 67. Have I lost my mind, or is the OSX build ignoring things passed to scons altogether?

[joevenzon]

What does the compiler command line that scons executes look like after adjusting the SConstruct file as you have? I wonder if you need a # symbol in there like the others, and what that symbol means.

[cotharyus]

Ok, here's the scoop. As close as I can tell, all the scons work on osx is wasted. At least if you build using xcode. I removed the header files from the includes directory again, and edited the xcode project file, and got it to compile this far again. I keep coming up with undefined symbols, which I know means the linker can't find the libs it's trying to link against. I've edited the project file again to include /usr/local/lib but still getting the same thing. Maybe I'll figure this out....

[cotharyus]

/usr/bin/ld: Undefined symbols:
_ov_clear
_ov_info
_ov_open
_ov_pcm_total
_ov_read
/Users/Projects/build/vdrift.build/Release-Deployment/vdrift.build/Objects-normal/ppc/sound.o reference to undefined _ov_clear
/Users/Projects/build/vdrift.build/Release-Deployment/vdrift.build/Objects-normal/ppc/sound.o reference to undefined _ov_info
/Users/Projects/build/vdrift.build/Release-Deployment/vdrift.build/Objects-normal/ppc/sound.o reference to undefined _ov_open
/Users/Projects/build/vdrift.build/Release-Deployment/vdrift.build/Objects-normal/ppc/sound.o reference to undefined _ov_pcm_total
/Users/Projects/build/vdrift.build/Release-Deployment/vdrift.build/Objects-normal/ppc/sound.o reference to undefined _ov_read
collect2: ld returned 1 exit status
/usr/bin/ld: Undefined symbols:
_ov_clear
_ov_info
_ov_open
_ov_pcm_total
_ov_read
/Users/Projects/build/vdrift.build/Release-Deployment/vdrift.build/Objects-normal/ppc/sound.o reference to undefined _ov_clear
/Users/Projects/build/vdrift.build/Release-Deployment/vdrift.build/Objects-normal/ppc/sound.o reference to undefined _ov_info
/Users/Projects/build/vdrift.build/Release-Deployment/vdrift.build/Objects-normal/ppc/sound.o reference to undefined _ov_open
/Users/Projects/build/vdrift.build/Release-Deployment/vdrift.build/Objects-normal/ppc/sound.o reference to undefined _ov_pcm_total
/Users/Projects/build/vdrift.build/Release-Deployment/vdrift.build/Objects-normal/ppc/sound.o reference to undefined _ov_read
collect2: ld returned 1 exit status
Build failed (1 error)


Ok - what library should those functions be in?