supress gcc warnings

[Tom]

If compiled, there are some compiler warnings.

This patch eliminates most of them:

http://pastebin.com/m8716091

These ones are 'still there':

Code:

scons: warning: The Options class is deprecated; use the Variables class instead.
File "/home/tom/programming/vdrift.svn2git/SConstruct", line 9, in <module>

scons: warning: The BoolOption() function is deprecated; use the BoolVariable() function instead.
File "/home/tom/programming/vdrift.svn2git/SConstruct", line 13, in <module>
In file included from src/nedmalloc.c:64:
include/malloc.c.h: In function 'change_mparam':
include/malloc.c.h:3038: warning: value computed is not used
In file included from src/nedmalloc.c:64:
include/malloc.c.h: In function 'internal_mallinfo':
include/malloc.c.h:3331: warning: value computed is not used
In file included from src/nedmalloc.c:64:
include/malloc.c.h: In function 'internal_malloc_stats':
include/malloc.c.h:3370: warning: value computed is not used
In file included from src/nedmalloc.c:64:
include/malloc.c.h: In function 'sys_alloc':
include/malloc.c.h:3874: warning: value computed is not used
In file included from src/nedmalloc.c:64:
include/malloc.c.h: In function 'sys_trim':
include/malloc.c.h:4119: warning: value computed is not used
In file included from src/nedmalloc.c:64:
include/malloc.c.h: In function 'ialloc':
include/malloc.c.h:4479: warning: value computed is not used
In file included from src/nedmalloc.c:64:
include/malloc.c.h: In function 'create_mspace':
include/malloc.c.h:4971: warning: value computed is not used
In file included from src/nedmalloc.c:64:
include/malloc.c.h: In function 'create_mspace_with_base':
include/malloc.c.h:4990: warning: value computed is not used
src/nedmalloc.c: In function 'InitPool':
src/nedmalloc.c:547: warning: value computed is not used
src/nedmalloc.c: In function 'nedpmallinfo':
src/nedmalloc.c:873: warning: missing initializer
src/nedmalloc.c:873: warning: (near initialization for 'ret.ordblks')
bullet/BulletCollision/Gimpact/gim_box_set.cpp: In member function 'unsigned int GIM_BOX_TREE::_sort_and_calc_splitting_index(gim_array<GIM_AABB_DATA>&, unsigned int, unsigned int, unsigned int)':
bullet/BulletCollision/Gimpact/gim_box_set.cpp:113: warning: unused variable 'unbal'
bullet/BulletCollision/Gimpact/btGImpactQuantizedBvh.cpp: In member function 'int btQuantizedBvhTree::_sort_and_calc_splitting_index(GIM_BVH_DATA_ARRAY&, int, int, int)':
bullet/BulletCollision/Gimpact/btGImpactQuantizedBvh.cpp:174: warning: unused variable 'unbal'
bullet/BulletCollision/Gimpact/btGImpactBvh.cpp: In member function 'int btBvhTree::_sort_and_calc_splitting_index(GIM_BVH_DATA_ARRAY&, int, int, int)':
bullet/BulletCollision/Gimpact/btGImpactBvh.cpp:153: warning: unused variable 'unbal'

[joevenzon]

Hey, thanks for making a forum thread for this!

Those warnings are from the nedmalloc and bullet code. I forgot to mention this before, but I'd rather have fixes to bullet/nedmalloc applied upstream because I copy over the latest code whenever they make new releases.

Also with almost all of the patches you sent me, my version of patch seems to choke with "malformed patch" errors when it encounters all of these extra newlines in the files, for example:

Code:

@@ -184,7 +183,7 @@ BT_DECLARE_ALIGNED_ALLOCATOR();
    {
    }
    btBroadphasePair(btBroadphaseProxy& proxy0,btBroadphaseProxy& proxy1)
-        :m_algorithm(0), m_internalInfo1(0)
+        :m_pProxy0(NULL), m_pProxy1(NULL), m_algorithm(0), m_internalInfo1(0)
    {
        //keep them sorted, so the std::set operations work
        if (&proxy0 < &proxy1){
diff --git a/bullet/BulletCollision/BroadphaseCollision/btDbvt.h b/bullet/BulletCollision/BroadphaseCollision/btDbvt.h
index 0b66f8a..4f2f352 100644
--- a/bullet/BulletCollision/BroadphaseCollision/btDbvt.h
+++ b/bullet/BulletCollision/BroadphaseCollision/btDbvt.h
@@ -129,6 +129,8 @@ subject to the following restrictions:
/* btDbvtAabbMm            */

struct    btDbvtAabbMm

{

+    btDbvtAabbMm():mi(), mx(){}
+
    DBVT_INLINE btVector3            Center() const    { return((mi+mx)/2); }

    DBVT_INLINE btVector3            Lengths() const    { return(mx-mi); }

    DBVT_INLINE btVector3            Extents() const    { return((mx-mi)/2); }

Note how starting with the patches to btDbvt.h, there are new lines every other line... any idea what's going on there, or how I could get patch to stop choking on 'em?

[Tom]

http://pastebin.com/m616fafde

Try again :-)

It was possibly a windows-linux bug…

There where some '^M' at the end of many lines. That where the lines you saw double lines. Whyever! I saw that after someone edited something with windows… Therefore the guess.


Ok, waiting for the bullet/nedmalloc patches ;-)

[joevenzon]

OK, added the patch from your previous post to R2514 after removing the bullet changes.

[Tom]

Is it easier to copy al the code over and over again instead of using the packages from linux distributions or just because you want to use the HEAD of the sources?

Tom

[joevenzon]

Bullet is not supposed to be installed as a system-wide library. It's supposed to be as source code from inside a project, as VDrift uses it. Straight from the mouth of Erwin, the author of bullet:

http://www.bulletphysics.com/Bullet/phpB...273#p12273

I'm not sure why distributions package it up as a system-wide library, but it leads to all kinds of problems, because bullet isn't set up with that in mind.

I'm not aware of any nedmalloc packages for ubuntu, so I just included the source in the project since it's only a couple of files.