abs1nth Wrote:Marty Wrote:The function texturedPolygon() in SDL_gfxPrimitives.c has two returns without a value (around line 3586). I assume it should return -1 there.
i don't think we should touch SDL_gfxPrimitives since it isn't our code.
(although the auther is receptive to patches, you can send this fix directly to him if you want)
actually adding these files to the project was stop-gap hack....i will include a proper framework for SDL_gfx in the future.
Fair enough. I wasn't aware that SDL_gfxPrimitives came from elsewhere.
Out of curiosity, I did have a quick look at the LGPL. Section 3 says that you can opt to apply the terms of the GPL to anything liscenced under LGPL so if I'm interpreting things correctly, as long as "LGPL" in line 5 is replaced with "GPL" then the code can be legitimately changed.
In fact, if you want to nit-pick, this should probably be done anyway since section 2 says that any derived work must also be a library. The only way to include LGPL code in an application is by applying the GPL terms as per section 3 and changing all "LGPL" references to "GPL". Please correct me if I'm wrong.
BTW: Sorry for dragging this thread down with legal type stuff. I know how painful that can sometimes be.
LGPL link
here for the curious.
