Login

cotharyus · 12-13-2008, 09:30 AM,

Have we had any successful OS X builds since refactor? I gave it a run this morning because I had a few minutes (where does my time go?) and it fails pretty horribly. I'm guessing there have been no updates to the OS X project files.

***joevenzon*** · 12-14-2008, 01:20 AM,

I think you are correct. As far as I know it *should* compile fine, though, once the project files are set up correctly....

cotharyus · 12-16-2008, 12:44 PM,

Yeah, the project file is the biggy though. I've messed with minor things before, but this looks like it might require a complete redo. I'm picking at it, but I don't have it right yet.

***joevenzon*** · 12-16-2008, 10:38 PM,

OK, let me know if you run into any compile problems.

abs1nth · 12-18-2008, 08:44 AM,

ok r2261 should at least compile, didn't have luck running it yet though.

but you need to expand bullet-2.73-sp1.tgz, i don't know why it is stored only compressed in svn.

btw. why was the PCH stuff removed? i had to add ifdefs for includes all over the place again ... ;-(

bye, julian

charlieg · 12-18-2008, 12:30 PM,

Latest SVN (revision 2262) doesn't compile here (Linux).

Code:
src/game.cpp: In member function âvoid GAME::InitializeThreading()â:

src/game.cpp:150: error: âinfoâ was not declared in this scope

src/game.cpp:151: error: âinfoâ was not declared in this scope

scons: *** [build/game.o] Error 1

***joevenzon*** · 12-18-2008, 05:25 PM,

R2263 is fixed for unix. Julian accidentally deleted a line when he replaced the #ifdef block -- no biggie, easy fix.

***joevenzon*** · 12-18-2008, 05:28 PM,

abs1nth Wrote:why was the PCH stuff removed?

Ignorance on my part of what the pch stuff was for when I did the refactor. Sorry about that. :oops:

abs1nth · 12-20-2008, 08:45 AM,

here is a patch that re-adds the pch stuff:
http://de.pastebin.ca/1290168

probably needs some adjusting on win/lin and either some scons magic to include pch.h in every compile or add a include pch.h to every file. don't remember how that was done previously.

***joevenzon*** · 12-20-2008, 02:38 PM,

abs1nth Wrote:either some scons magic to include pch.h in every compile or add a include pch.h to every file. don't remember how that was done previously.

Previously there was an #include "pch.h" in every file. It seems kind of messy to do it that way, but I can't think of any problem with it besides just obscuring exactly what external library includes your file is depending on.

But, prior to the patch you already fixed the includes for everything to be correct on OSX? If so, then maybe it's not worth the effort to add #include pch.h everywhere; I don't expect any new external dependencies. Thoughts?

abs1nth · 12-21-2008, 09:59 AM,

joevenzon Wrote:If so, then maybe it's not worth the effort to add #include pch.h everywhere; Thoughts?

well, of course all other includes are removed, so it is a net-win (LoC wise) ;-)

also if the pch.h is actually precompiled there is a significant compile-time speedup - but of course there is the issue of doing this with scons. a quick search yields this:
http://www.scons.org/wiki/GchBuilder

Login
Username:
Password:	Lost Password?
	Remember me