Building on OSX without warnings.

[Marty]

The source I checked out from SVN throws a handfull of warnings at me when building on OSX. These are easily fixed as follows:

Move the -Wno-non-virtual-dtor option from "Other Warning Flags" to "Other C++ flags" so that it doesn't get applied to C files (Double click on the vdrift target, select "GNU C/C++ Compiler 4.0" from "Collection" option, cut and paste as appropriate).

The function texturedPolygon() in SDL_gfxPrimitives.c has two returns without a value (around line 3586). I assume it should return -1 there.

I know these warnings aren't a big deal but it's nice if the project builds cleanly. Is there any chance of having these changes applied to the source repository by someone who has the required permissions?

Thanks.

[thelusiv]

Yeah it occasionally annoys me when gcc complains about -Wno-non-virtual-dtor not applying to C files (we need to fix this in our SCons build system for Linux). It hasn't been a major issue though...

abs1nth will probably have more to say about this he manages the OS X build.

[abs1nth]

Move the -Wno-non-virtual-dtor option from "Other Warning Flags" to "Other C++ flags" so that it doesn't get applied to C files (Double click on the vdrift target, select "GNU C/C++ Compiler 4.0" from "Collection" option, cut and paste as appropriate).

i will do that.
i'd really like to see these warnings fixed instead of telling the compiler to shut up about them ;-)

The function texturedPolygon() in SDL_gfxPrimitives.c has two returns without a value (around line 3586). I assume it should return -1 there.

i don't think we should touch SDL_gfxPrimitives since it isn't our code.
(although the auther is receptive to patches, you can send this fix directly to him if you want)
actually adding these files to the project was stop-gap hack....i will include a proper framework for SDL_gfx in the future.

[Marty]

The function texturedPolygon() in SDL_gfxPrimitives.c has two returns without a value (around line 3586). I assume it should return -1 there.

i don't think we should touch SDL_gfxPrimitives since it isn't our code.
(although the auther is receptive to patches, you can send this fix directly to him if you want)
actually adding these files to the project was stop-gap hack....i will include a proper framework for SDL_gfx in the future.

Fair enough. I wasn't aware that SDL_gfxPrimitives came from elsewhere.

Out of curiosity, I did have a quick look at the LGPL. Section 3 says that you can opt to apply the terms of the GPL to anything liscenced under LGPL so if I'm interpreting things correctly, as long as "LGPL" in line 5 is replaced with "GPL" then the code can be legitimately changed.

In fact, if you want to nit-pick, this should probably be done anyway since section 2 says that any derived work must also be a library. The only way to include LGPL code in an application is by applying the GPL terms as per section 3 and changing all "LGPL" references to "GPL". Please correct me if I'm wrong.

BTW: Sorry for dragging this thread down with legal type stuff. I know how painful that can sometimes be.
LGPL link here for the curious.

[abs1nth]

bah, (L)GPL *grml*

i've built a framework for SDL_gfx now, should commit that soon (together with the changes to the project to reduce the warnings)