+- Forums (https://www.vdrift.net/Forum)
+-- Forum: Project (https://www.vdrift.net/Forum/forumdisplay.php?fid=4)
+--- Forum: Development (https://www.vdrift.net/Forum/forumdisplay.php?fid=9)
+--- Thread: PATCH: src/main.cpp various modifications. (/showthread.php?tid=1513)
PATCH: src/main.cpp various modifications. - antoniovazquez - 06-05-2011
I've started a walk through all the code in "execution" order. I've started in src/main.cpp to have a better understanding of the code. Just because of that I've decided to rewrite the first file.
It now has the GPL header (as GPL says that every source file should have it but I understand it is not a problem), the "release_mouse" function is first declared after includes and not between them (just for better reading...), I've deleted some comments with old code that seemed unuseful (review them please), Now coments folow some rules (// First capital letter and a dot at the end.) and log now uses the words "INFO" and "ERROR" always.
Hope you use it.
http://www.mediafire.com/file/1um9bgy064mpteu/main.cpp_rewrite.patch
- NaN - 06-05-2011
Looks good. Can you prepend the std namespace to std components (std:
tring). Hope to see more patches.
- antoniovazquez - 06-06-2011
NaN Wrote:Looks good. Can you prepend the std namespace to std components (std:
Sorry I sometimes have problems with English as I'm Spanish. What do you mean?
Code:
std::string
#include <string>Code:
#include <string>
std::stringAnd now that I remember "Vásquez" or "Vázques" is from South America, I'm from Spain, Europe and I'm "Antonio Vázquez". I don't know if it was a simple misstype but it anyway it doesn't matter
. Thanks for your support.
- NaN - 06-06-2011
Quote:What do you mean?Just add std:: (namespace qualifier) to string and other std components.
Quote:it was a simple misstypePure sloppiness on my part, sorry.